Skip to content

zTalkbox, xScrFx & misc#590

Merged
SquareMan merged 8 commits intobfbbdecomp:mainfrom
LivewireCB:dev8
Aug 24, 2025
Merged

zTalkbox, xScrFx & misc#590
SquareMan merged 8 commits intobfbbdecomp:mainfrom
LivewireCB:dev8

Conversation

@LivewireCB
Copy link
Contributor

@LivewireCB LivewireCB commented Aug 13, 2025

  • Overhauled the zTalkbox namespace along with doing functions there.

  • Filled out quite a bit of xScrFx

    • Can't do the big functions as theres currently a problem with xScrFxDrawBox

  • Did "FloatingPointErrorHandler" in iSystem

@github-actions
Copy link

github-actions bot commented Aug 13, 2025

⚠️ 🔥

+19543 bytes
🆗 Bot Rating: If I could feel emotions, I would be crying tears of joy right now.

Regressions: 3

⚠️ main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::cb_dispatch(xBase*, xBase*, unsigned int, const float*, xBase*) -44 bytes -> 87.74%
⚠️ main/SB/Game/zTalkBox - ztalkbox::stop_wait(unsigned int) -36 bytes -> 10.00%
⚠️ main/SB/Game/zTalkBox - ztalkbox::show() -108 bytes -> 25.00%

Progress: 31

📈 main/SB/Game/zTalkBox - .bss +18254 bytes -> 99.57%
📈 main/SB/Game/zTalkBox - .text +272 bytes -> 11.67%
📈 main/SB/Core/x/xScrFx - .text +637 bytes -> 12.67%
📈 main/SB/Core/x/xScrFx - .bss +136 bytes -> 50.00%
📈 main/SB/Core/x/xScrFx - .sdata2 +26 bytes -> 42.11%
📈 main/SB/Core/x/xScrFx - .sbss +28 bytes -> 71.43%
📈 main/SB/Core/x/xScrFx - .sdata +2 bytes -> 9.52%
✅ main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::trigger_pads(unsigned int) +264 bytes -> 100.00%
📈 main/SB/Core/x/xScrFx - xScrFxFade(iColor_tag*, iColor_tag*, float, void (*)(void), int) +12 bytes -> 6.67%
📈 main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::trigger(unsigned int) +36 bytes -> 27.27%
📈 main/SB/Core/x/xScrFx - xScrFxDrawScreenSizeRectangle() +69 bytes -> 54.29%
✅ main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::speak_stop() +120 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxUpdate(RwCamera*, float) +96 bytes -> 100.00%
📈 main/SB/Core/x/xScrFx - InterpCol(float, unsigned char, unsigned char) +4 bytes -> 4.35%
✅ main/SB/Core/x/xScrFx - xScrFxLetterbox(int) +80 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxRender(RwCamera*) +64 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFXGlareInit() +52 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxFadeInit() +48 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxInit() +44 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxReset() +32 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFXGlareReset() +32 bytes -> 100.00%
✅ main/SB/Game/zTalkBox - ztalkbox::permit(unsigned int, unsigned int) +32 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxIsLetterbox() +24 bytes -> 100.00%
📈 main/SB/Core/x/xScrFx - xScrFxLetterBoxInit() +16 bytes -> 80.00%
📈 main/SB/Core/x/xScrFx - xScrFxLetterboxReset() +16 bytes -> 80.00%
✅ main/SB/Core/x/xScrFx - xScrFxStopFade() +16 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxIsFading() +16 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxLetterBoxSetSize(float) +8 bytes -> 100.00%
✅ main/SB/Core/x/xScrFx - xScrFxLetterBoxSetAlpha(unsigned char) +8 bytes -> 100.00%
✅ main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::state_type::start() +4 bytes -> 100.00%
✅ main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::state_type::stop() +4 bytes -> 100.00%

@SquareMan SquareMan merged commit f3df824 into bfbbdecomp:main Aug 24, 2025
5 checks passed
LivewireCB added a commit to LivewireCB/bfbb-decomp that referenced this pull request Sep 2, 2025
@LivewireCB
zTalkbox, xScrFx & misc (bfbbdecomp#590)
193a788 
* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton

* zTalkbox work and xScrFx

* Floating point error handler func
SquareMan added a commit that referenced this pull request Sep 22, 2025
@LivewireCB @SquareMan
zNPCMessenger work and Misc fixes (#596)
1bce52d 
* ported zNPCSupport code, zNPCTypeCommon

* build fix

* zNPCTypeBossPlankton & zNPCTypeBossSB2 work (#589)

* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton

* zTalkbox, xScrFx & misc (#590)

* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton

* zTalkbox work and xScrFx

* Floating point error handler func

* zAssetTypes done for now (#588)

* Progress

* zAssetTypes done for now

* Mark zAssetTypes equivalent

* Couple functions in zNPCMessenger. Misc fixes

* build fix

* xFX work and misc

* Dutchman + misc

* Review Fixes

---------

Co-authored-by: Steven Casper <sebastiancasper3@gmail.com>
JoshSanch pushed a commit that referenced this pull request Oct 3, 2025
@LivewireCB @SquareMan
Cleaned Code, Implemented fixes (#601)
fe3235e 
* ported zNPCSupport code, zNPCTypeCommon

* build fix

* zNPCTypeBossPlankton & zNPCTypeBossSB2 work (#589)

* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton

* zTalkbox, xScrFx & misc (#590)

* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton

* zTalkbox work and xScrFx

* Floating point error handler func

* zAssetTypes done for now (#588)

* Progress

* zAssetTypes done for now

* Mark zAssetTypes equivalent

* ported zNPCSupport code, zNPCTypeCommon

* Cleaned code

* Forgot to remove %

---------

Co-authored-by: Steven Casper <sebastiancasper3@gmail.com>
JoshSanch pushed a commit that referenced this pull request Oct 18, 2025
@LivewireCB @SquareMan
zNPCGoalRobo work + misc (#614)
7a66b2c 
* ported zNPCSupport code, zNPCTypeCommon

* build fix

* zNPCTypeBossPlankton & zNPCTypeBossSB2 work (#589)

* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton

* zTalkbox, xScrFx & misc (#590)

* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton

* zTalkbox work and xScrFx

* Floating point error handler func

* zAssetTypes done for now (#588)

* Progress

* zAssetTypes done for now

* Mark zAssetTypes equivalent

* ported zNPCSupport code, zNPCTypeCommon

* Cleaned code

* Forgot to remove %

* zNPCGoalRobo

---------

Co-authored-by: Steven Casper <sebastiancasper3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LivewireCB @SquareMan